Unable to edit photos; redirected back to the file list (NC 29 & 30)

[RyoKub]

Description

When accessing the Photos app at http://[nextcloud]/apps/photos/ and clicking on the viewer to view images, the interface allows for normal interaction. However, attempting to edit an image by clicking the pencil icon results in being redirected back to the file list screen instead of opening the editing interface.

Error Message

Console in Browser : [Deprecation] Listener added for a 'DOMNodeInserted' mutation event. This event type is deprecated, and will be removed from this browser very soon. Usage of this event listener will cause performance issues today, and represents a large risk of future site breakage. Consider using MutationObserver instead. See https://chromestatus.com/feature/5083947249172480 for more information.

This issue occurs consistently across different browsers including Edge and Chrome on Windows, and Safari on iPad.

Steps to Reproduce

1. Open the Nextcloud Photos app at http://[nextcloud]/apps/photos/.
2. Click on any photo to view it.
3. Attempt to edit the photo by clicking the pencil icon.
4. Observe that instead of transitioning to the edit mode, the interface redirects back to the file list.

Expected behavior

The expected behavior is to transition to the photo editing interface as was the case in previous version 28.0.3.

Actual behavior

Clicking the edit icon redirects back to the photo file list, and a deprecation warning is logged in the console.

Environment

• Nextcloud version: 29.0.0
• Photos app version: 2.5.0
• Operating system: Windows and iOS
• Browser: Edge, Chrome, Safari

Additional context

This issue prevents any editing functionality within the Photos app, which was functional in the previous version 28.0.3. The same behavior is observed across multiple platforms and browsers indicating a possible issue with the app's handling of deprecated browser features.

[dennisheitmann]

Same here. Nextcloud 29.0.0.19 with photos 2.5.0. Tested with Chrome and Firefox on Linux.

After not editing was not working, also display of photos does not work anymore until reload of page:

[ralfi]

confirm, memories works

[bobobo-git]

confirm it.
also look at https://help.nextcloud.com/t/editing-in-images-doesnt-work/189508

😀

[bobobo-git]

the errormessage from above is also applied in NC 27.5.1 but there the fotoapp reacts correct

[bobobo-git]

i took the viewer app from a nextcloud 27 , edited the info.xml in the appinfo-folder (max-version="29")
and and overwrote the existing viewer app

and then (after an updatemessage) it worked ok.

so it seam to be the viewer app
(it isn't loaded in webpack when using the nc 29 version)

maybe it is time to contact the author of the viewer app
author mail="skjnldsv@protonmail.com" John Molakvoæ from the info.xml

the content of folder js in the app looks strange
no js files but mjs files ...

[bobobo-git]

i replaced all in js folder with the content of the js folder from the nc27 version

after an update message everything runs ok in nc 29
BUT the editor for text / md wont work anymore.

in a fresh installation nc 29.0.1 , all apps deactivated, a click on a jpg shows it but will not load the editor if clicked on the pencil.

[bobobo-git]

the image editor (*) fails to load in nc 29.

implementatin of filerobot image editor https://scaleflex.github.io/filerobot-image-editor/

read here https://nextcloud.com/blog/how-we-got-to-the-new-nextcloud-photos/

[joshtrichards]

Reproduced. Editing is provided by Viewer not the Photos app. Transferred to that repo.

[alexanderdd]

Still broken in NC 30.0.0 beta 5 (tested on c.nc.com)

Weird also: after unsuccessfully trying to edit and getting thrown back to files list, and clicking an image again, you see the error "no plugin avialable to view this file type" (German "Es ist kein Plugin zum Anzeigen dieses Dateityps verfügbar")

[thlehmann-ionos]

Without more in-depth investigation: the problem seems to be related to the bundling/module-loading.

The error is not reproducible in a dev environment with debug => true. The difference here is the script loading does not add a cache-buster to the URL in dev mode, while in production mode, it's added.

In production one can observe that viewer-main.mjs is loaded a second time without a cache buster when clicking the pencil icon.

I assume that the viewer code loads and executes a second time, this time with no handlers being registered through registerHandler() (because this already happend). When stepping through the code one can see that openFileInfo() upon pencil icon click failed due to registeredHandlers being empty. Yet, when breaking in registerHandler() on page load we observe handlers being registered.

Vite does not seem to be aware of the added cachebuster when lazy-importingfilerobot-image-editor in ImageEditort.vue's mounted()

(Edits: clarifications, formatting)

[thlehmann-ionos]

I'm not familiar enough with the setup and Vite's bundling internals, and I am happy to attempt fixing it if someone could give me some hints here.

[dolorosus]

At the moment it does not look like this error will be fixed. I therefore suggest removing the pencil icon (edit).