-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make build-graph
recur until all transitive deps are analyzed
#381
Conversation
Thanks for looking into this.
To compute a hash that changes when a form or a dependency changes, we must have a hash for each of its dependencies. The warning exists for when that's not the case so it is something that actually needs to be fixed. |
Co-authored-by: Phillip Mates <phillipmates@gmail.com>
build-graph
recur until all transitive deps are analyzed
@mk I pushed a fix for Windows. I also fixed some reflection issues in analyzer.clj (since I had to do some interop I found it better to enable that). I also added an alias for the cognitect test runner which I find easier to work with, I hope that's ok. |
Until now Clerk did not analyze the full transitive dependency graph which could lead to Clerk not detecting a change properly. Analysis is now recursive which means it's taking a bit longer initially. We cache analysis results per file in memory so subsequent analysis should be fast. We will follow up with visualizing the progress of analysis & execution.
Also discovered cases where classes instead of symbols could end up in the dependency graph and introduced normalization to symbols.
This also gets rid of the
->hash must be ifn?
warning which fixes #375.