Add clerk/resolve-aliases
and make alias resolution explicit
#410
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the alias resolution explicit via a new
clerk/resolve-aliases
function. The recommendation is now to use the full namespace in:render-fn
s or make the conversion explicit usingclerk/resolve-aliases
.I've also removed the automatic resolution from
->viewer-fn/eval
because it would depend on the evaluation context (a notebook that defines a viewer using aliases would render correctly but things could break if that viewer is being reused from another namespace that doesn't define the same aliases).Lastly we've dropped the previously defined aliases:
We should think about temporarily bringing them back and log a warning instead before the next release, so folks have time to migrate but I'd like to make sure all our notebooks aren't using them anymore.