Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need uncompress_cog_uk_metadata and compress_cog_uk_metadata? #450

Open
joverlee521 opened this issue Jun 17, 2024 · 1 comment
Open

Comments

@joverlee521
Copy link
Contributor

Context

A question that came up as I was working on #240: Do we need to uncompress/compress the COG UK metadata during the workflow?

The transform_genbank_metadata rule uses the gzipped COGUK metadata file directly. I do not see any other rule consuming the uncompressed COG UK metadata as input, so it seems like we are uncompressing/compressing for the sake of being able to have a copy on AWS S3 that is zstd compressed.

It's not clear how much resources these jobs actually take up since we don't have benchmark files (yet!). I'll revisit this question once we have more data from workflow runs.

@joverlee521
Copy link
Contributor Author

Ah, this might also be a result of our upload-to-s3 and download-from-s3 scripts not having the option to skip compression during transfer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant