Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --stats when we upgrade to Snakemake v8 #452

Open
Tracked by #4
joverlee521 opened this issue Jun 18, 2024 · 1 comment
Open
Tracked by #4

Remove --stats when we upgrade to Snakemake v8 #452

joverlee521 opened this issue Jun 18, 2024 · 1 comment

Comments

@joverlee521
Copy link
Contributor

Follow up to #451.

We are using the Snakemake --stats flag to get workflow stats for GISAID and GenBank ingest to help with #446. If/when we ever upgrade Snakemake to v8, the --stats flag is no longer supported and will need to be removed.

Upgrading Snakemake is dependent on updating the nextstrain docker-base image and then running the update-image workflow in this repo since the workflows are using the nextstrain/ncov-ingest Docker image.

Alternatively, we can pin Snakemake <8 in this repo, but we can make that decision later.

@corneliusroemer corneliusroemer changed the title Remove --stats if/when we upgrade to Snakemake v8 Remove --stats when we upgrade to Snakemake v8 Aug 22, 2024
@corneliusroemer
Copy link
Member

I don't see why we shouldn't support snakemake 8. I think it's bad we get stuck at old versions and can't use new features.

It's good that we are updating now but I agree that pinning should be easy workaround in case we don't have time to change the worklow immediately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants