We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.2.10
Hey, I just discovered that I can't have fullscreen modal with scrollable body. If I try to eg.
<Modal isOpen={isOpen} onOpenChange={onOpenChange} scrollBehavior="inside" size="full" >
it results in modal stopping being full screen.
https://codesandbox.io/p/devbox/heuristic-jasper-4hd333?file=%2FApp.jsx%3A24%2C19
When using modal add both props size="full" and scrollBehavior="inside"
Modal should stay fullscreen
Windows
Chrome
The text was updated successfully, but these errors were encountered:
ENG-623 [BUG] - Modal - size="full" not working correctly with scrollBehavior="inside"
Sorry, something went wrong.
When scrollBehavior="inside" is set, 7.5rem is reduced from the total height
scrollBehavior="inside"
inside: { base: "max-h-[calc(100%_-_7.5rem)]", body: "overflow-y-auto", },
Maybe there is some design decision taken for that calculation, but the below code can fix this bug
inside: { base: "max-h-full", body: "overflow-y-auto", },
Note:- If needed i could generate a PR for this.
Successfully merging a pull request may close this issue.
NextUI Version
2.2.10
Describe the bug
Hey, I just discovered that I can't have fullscreen modal with scrollable body. If I try to eg.
it results in modal stopping being full screen.
Your Example Website or App
https://codesandbox.io/p/devbox/heuristic-jasper-4hd333?file=%2FApp.jsx%3A24%2C19
Steps to Reproduce the Bug or Issue
When using modal add both props size="full" and scrollBehavior="inside"
Expected behavior
Modal should stay fullscreen
Screenshots or Videos
Operating System Version
Windows
Browser
Chrome
The text was updated successfully, but these errors were encountered: