Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - International Calendars not working in documentation #3339

Closed
wingkwong opened this issue Jun 27, 2024 · 6 comments · Fixed by #3363
Closed

[BUG] - International Calendars not working in documentation #3339

wingkwong opened this issue Jun 27, 2024 · 6 comments · Fixed by #3363
Labels
📋 Scope : Docs Related to the documentation 🚀 Type: Good First Issue Good for newcomers

Comments

@wingkwong
Copy link
Member

wingkwong commented Jun 27, 2024

NextUI Version

2.4.2

Describe the bug

Documentation (incorrect behaviour): https://nextui.org/docs/components/calendar#international-calendars

image

Storybook (correct behaviour): https://storybook.nextui.org/?path=/story/components-calendar--international-calendars&globals=locale:da-DK

image

Your Example Website or App

No response

Steps to Reproduce the Bug or Issue

Compare the difference between documentation and storybook for International Calendars

Expected behavior

The locale should be applied

Screenshots or Videos

No response

Operating System Version

macOS

Browser

Chrome

Copy link

linear bot commented Jun 27, 2024

@wingkwong wingkwong added 🚀 Type: Good First Issue Good for newcomers 📋 Scope : Docs Related to the documentation labels Jun 27, 2024
@sac1hin
Copy link

sac1hin commented Jun 28, 2024

Can you explain more about the issue?

@wingkwong
Copy link
Member Author

@sac1hin Sure. If you look at international calendars in documentation. You can see the locale is set to zh-CN-u-ca-chinese. However, in the preview, it still shows in English while it should show in Chinese. In the storybook, you can see it renders correctly.

<I18nProvider locale="zh-CN-u-ca-chinese">
  <Calendar aria-label="Date (International Calendar)" />
</I18nProvider>

@Mihir867
Copy link

Hi, Can you assign this to me ?

@wingkwong
Copy link
Member Author

@Mihir867 There's a PR already. Please check out other issues.

@Mihir867
Copy link

@Mihir867 There's a PR already. Please check out other issues.

Ohh sure!!
Could you guide me with something I can work on, I'm actually quite new to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📋 Scope : Docs Related to the documentation 🚀 Type: Good First Issue Good for newcomers
Projects
None yet
3 participants