Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ref in form component #4279

Merged
merged 1 commit into from
Dec 8, 2024
Merged

fix: ref in form component #4279

merged 1 commit into from
Dec 8, 2024

Conversation

jrgarciadev
Copy link
Member

@jrgarciadev jrgarciadev commented Dec 8, 2024

Closes #

📝 Description

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

  • New Features

    • Added support for refs in the Form component, allowing direct access to the underlying DOM node or component instance.
  • Tests

    • Introduced a new test suite for the Form component to verify rendering behavior and ref assignment.

Copy link

changeset-bot bot commented Dec 8, 2024

🦋 Changeset detected

Latest commit: f2695e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@nextui-org/form Patch
@nextui-org/autocomplete Patch
@nextui-org/checkbox Patch
@nextui-org/date-input Patch
@nextui-org/date-picker Patch
@nextui-org/input-otp Patch
@nextui-org/input Patch
@nextui-org/radio Patch
@nextui-org/select Patch
@nextui-org/react Patch
@nextui-org/table Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-docs-v2 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 8, 2024 11:48am
nextui-storybook-v2 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 8, 2024 11:48am

Copy link
Contributor

coderabbitai bot commented Dec 8, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request introduce reference support to the Form component within the "@nextui-org/form" package. This enhancement allows users to attach refs to the Form component, enabling direct access to the underlying DOM node or component instance. The implementation involves modifying the Form component to use forwardRef, allowing it to forward refs to its underlying elements. Additionally, a new test suite is added to verify the rendering behavior and ref assignment of the Form component.

Changes

File Change Summary
.changeset/eighty-buttons-do.md Added ref support to the Form component in the "@nextui-org/form" package.
packages/components/form/tests/form.test.tsx Introduced a new test suite for the Form component, verifying rendering and ref assignment using React Testing Library.
packages/components/form/src/form.tsx Modified the Form component to use forwardRef, allowing ref forwarding to the underlying AriaForm component.

Possibly related PRs

Suggested reviewers

  • wingkwong

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 9b7c5e4 and f2695e2.

📒 Files selected for processing (3)
  • .changeset/eighty-buttons-do.md (1 hunks)
  • packages/components/form/__tests__/form.test.tsx (1 hunks)
  • packages/components/form/src/form.tsx (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant