Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ben made me do this #188

Merged
merged 10 commits into from
Aug 29, 2024
Merged

Ben made me do this #188

merged 10 commits into from
Aug 29, 2024

Conversation

nvnieuwk
Copy link
Member

The title says it all!

(output workflow definitions are coming in another PR)

@nvnieuwk nvnieuwk requested a review from matthdsm August 29, 2024 07:49
@matthdsm
Copy link
Member

😠 Damn you Ben! Giving us all that work!

@matthdsm
Copy link
Member

PS: Consider dropping the linting CI test until the template release. That way we get all tests to pass.

if(entry != []){
output_roi.add(entry)
is_present = true
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete whitespace?

Copy link
Member

@matthdsm matthdsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nvnieuwk nvnieuwk merged commit aaf2d7a into dev Aug 29, 2024
28 of 30 checks passed
@nvnieuwk nvnieuwk deleted the ben-made-me-do-this branch August 29, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants