Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modules required for rnaseq pipeline #449

Merged
merged 8 commits into from
Apr 16, 2021
Merged

Conversation

drpatelh
Copy link
Member

@drpatelh drpatelh commented Apr 15, 2021

Udpdating modules required for the nf-core/rnaseq pipeline

  • Fix memory options in hisat2/build module
  • Bump Preseq version and added meta.yml to get lint tests passing
  • Add ability to auto-detect --genomeSAindexNbases for smaller genomes in star/genomegenerate module

@drpatelh drpatelh marked this pull request as draft April 15, 2021 15:54
@drpatelh
Copy link
Member Author

drpatelh commented Apr 15, 2021

hisat2/build tests are expected to fail here because we have had to rename the test directory to hisat2/build_test to get pytest to work.

star/genomegenerate tests are failing because the SARS-CoV-2 GTF doesn't have specific fields. Not much I can do about that for now but I have added placeholders to use the human data. Error is below:

Command error:

  Fatal INPUT FILE error, no exon lines in the GTF file: genome.gtf
  Solution: check the formatting of the GTF file, it must contain some lines with exon in the 3rd column.
            Make sure the GTF file is unzipped.
            If exons are marked with a different word, use --sjdbGTFfeatureExon .

  Apr 15 21:29:14 ...... FATAL ERROR, exiting

@drpatelh drpatelh marked this pull request as ready for review April 15, 2021 17:05
@drpatelh drpatelh changed the title Update HISAT2 build module Update modules required for rnaseq pipeline Apr 15, 2021
@drpatelh
Copy link
Member Author

Ready for review @JoseEspinosa @KevinMenden

Copy link
Contributor

@KevinMenden KevinMenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍
Bit annoying that we need three different tools now in the STAR module but what can you do 🤷

Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

software/hisat2/build/main.nf Show resolved Hide resolved
@drpatelh
Copy link
Member Author

Bit annoying that we need three different tools now in the STAR module but what can you do

Yup, but this will save alot of failures being reported for the rnaseq pipeline and others. Those additional tools should have quite a small storage footprint too. I will compare the size of the containers and post here

@drpatelh drpatelh merged commit d1c6082 into nf-core:master Apr 16, 2021
@drpatelh
Copy link
Member Author

Yup, almost 4 times the size 😏 But still much smaller than some of those Java beasts!

8.9M	depot.galaxyproject.org-singularity-star-2.6.1d--0.img
37M	depot.galaxyproject.org-singularity-mulled-v2-1fa26d1ce03c295fe2fdcf85831a92fbcbd7e8c2-59cdd445419f14abac76b31dd0d71217994cbcc9-0.img

@KevinMenden
Copy link
Contributor

Yeah that's still really small! 👍

@drpatelh drpatelh deleted the rnaseq branch April 26, 2021 10:23
Lucpen pushed a commit to Clinical-Genomics/modules that referenced this pull request Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants