Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FASTQE module #6914

Merged
merged 5 commits into from
Oct 31, 2024
Merged

Add FASTQE module #6914

merged 5 commits into from
Oct 31, 2024

Conversation

adamrtalbot
Copy link
Contributor

@adamrtalbot adamrtalbot commented Oct 30, 2024

Adds FASTQE, arguably the most important module.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@adamrtalbot
Copy link
Contributor Author

@nf-core-bot fix linting

Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best contribution ever

@adamrtalbot adamrtalbot added this pull request to the merge queue Oct 31, 2024
modules/nf-core/fastqe/meta.yml Outdated Show resolved Hide resolved
@adamrtalbot adamrtalbot removed this pull request from the merge queue due to a manual request Oct 31, 2024
Co-authored-by: Edmund Miller <20095261+edmundmiller@users.noreply.github.com>
@maxulysse maxulysse added this pull request to the merge queue Oct 31, 2024
Merged via the queue into nf-core:master with commit cab0b8f Oct 31, 2024
16 checks passed
@adamrtalbot adamrtalbot deleted the add_fastqe_module branch November 1, 2024 11:36
@adamrtalbot adamrtalbot mentioned this pull request Nov 2, 2024
1 task
@edmundmiller edmundmiller mentioned this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants