Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set a default docker registry outside of profile scope #95

Merged
merged 2 commits into from
May 12, 2023
Merged

Set a default docker registry outside of profile scope #95

merged 2 commits into from
May 12, 2023

Conversation

JoseEspinosa
Copy link
Member

The docker.registry configuration should always be set, as running on cloud executors will need to pull docker images but will not necessarily use the docker profile. See nf-core/tools#2286

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • CHANGELOG.md is updated.

@JoseEspinosa JoseEspinosa marked this pull request as ready for review May 12, 2023 13:33
@github-actions
Copy link

github-actions bot commented May 12, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 43c2b11

+| ✅ 157 tests passed       |+
!| ❗  10 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: lib/WorkflowProteinfold.groovy
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.
  • pipeline_todos - TODO string in check_samplesheet.py: Update the script to check the samplesheet
  • pipeline_todos - TODO string in check_samplesheet.py: Update the check_samplesheet function
  • pipeline_todos - TODO string in check_samplesheet.py: Update the column names for the input samplesheet
  • pipeline_todos - TODO string in usage.md: Add documentation about anything specific to running your pipeline. For general topics, please point to (and add to) the main nf-core website.

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-05-12 13:34:36

@JoseEspinosa JoseEspinosa merged commit 20387d3 into nf-core:dev May 12, 2023
@JoseEspinosa JoseEspinosa deleted the quay_fix branch May 12, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sateeshperi sateeshperi sateeshperi approved these changes

@adamrtalbot adamrtalbot adamrtalbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoseEspinosa @adamrtalbot @sateeshperi