Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide custom prefix/suffix for summary files to avoid overwriting #1050

Closed
JudithBernett opened this issue Jun 15, 2023 · 1 comment · Fixed by #1106
Closed

Provide custom prefix/suffix for summary files to avoid overwriting #1050

JudithBernett opened this issue Jun 15, 2023 · 1 comment · Fixed by #1106
Assignees
Milestone

Comments

@JudithBernett
Copy link

I have encountered an issue while running the pipeline in star_salmon mode with multiple batches and different multiqc titles.

I ran the pipeline in star_salmon mode in 2 batches (I split my samplesheet in half because of memory restraints) and specified the same output directory but two different multiqc titles. There are many outputs of the pipeline that have a sample-wise title but some of them don't, including the merged count files from salmon and the deseq2 pca files. Consequently, these files get overwritten by the second batch.

To mitigate this issue, I propose a small enhancement. It would be helpful if the multiqc title could be added to these summary files that would otherwise be overwritten. For example, instead of having files named salmon.merged.gene_tpm.tsv and deseq2.pca.vals.txt, they could be named salmon.merged.MULTIQC_TITLE.gene_tpm.tsv or deseq2.MULTIQC_TITLE.pca.vals.txt, respectively. This would ensure that the files remain distinct.

An alternative solution, for now, is to specify another output directory for the second batch.

For salmon, the name is hard-coded here:

For deseq2, an output prefix can be passed to the R script with "-p" or "--outprefix"
https://github.com/nf-core/rnaseq/blob/3bec2331cac2b5ff88a1dc71a21fab6529b57a0f/modules/local/deseq2_qc.nf#LL40C11-L40C11

Thank you for considering this enhancement suggestion!

@drpatelh drpatelh added this to the 3.12.1 milestone Oct 15, 2023
@pinin4fjords
Copy link
Member

Suggested fix is in #1106: 58bbc27

Adding proper prefix usage to the relevant local modules will allow users to configure them as they wish- including for the batched analysis described here.

@pinin4fjords pinin4fjords linked a pull request Nov 7, 2023 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants