Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salmon quant with UMI-tools does not work #668

Closed
grst opened this issue Jul 16, 2021 · 3 comments
Closed

Salmon quant with UMI-tools does not work #668

grst opened this issue Jul 16, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@grst
Copy link
Member

grst commented Jul 16, 2021

Running the pipeline with umi-tools and salmon quantification results in wrong counts.

There are two issues:

  • umi-tools is ran without the --paired flag with paired end data (TODO: fix module)
  • umi-tools does not include unmapped mates, while Salmon expects them to be present

See also discussion at CGATOxford/UMI-tools#465) and COMBINE-lab/salmon#684.

@grst grst added the bug Something isn't working label Jul 16, 2021
@grst grst self-assigned this Jul 16, 2021
@drpatelh
Copy link
Member

Module updated here nf-core/modules#583

drpatelh added a commit to drpatelh/nf-core-rnaseq that referenced this issue Jul 16, 2021
@drpatelh
Copy link
Member

Pipeline updated here #669

drpatelh added a commit that referenced this issue Jul 16, 2021
@grst
Copy link
Member Author

grst commented Jul 22, 2021

This solved the issue 🎉

The results of the DE are now very, very similar to the feature counts version I used before.
I think this is good enough for now! If Ian comes up with some magic to handle unpaired reads in UMI-tools we can still incorporate that later.

@grst grst closed this as completed Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants