Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed label in fastQC process #355

Merged
merged 2 commits into from
Dec 5, 2019
Merged

Fixed label in fastQC process #355

merged 2 commits into from
Dec 5, 2019

Conversation

FriederikeHanssen
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen commented Dec 5, 2019 •
edited
Loading

#345

Fixes the above.

PR checklist

  • PR is to dev rather than master
  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/rnaseq/tree/master/.github/CONTRIBUTING.md

@matrulda matrulda self-requested a review December 5, 2019 09:10
matrulda
matrulda requested changes Dec 5, 2019
View reviewed changes
Copy link

@matrulda matrulda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍 Can you add a comment about this in the Change log?

@matrulda
Copy link

matrulda commented Dec 5, 2019

@apeltzer Is there something I have to do to get the last check to start?

@matrulda matrulda merged commit a3c11c3 into nf-core:dev Dec 5, 2019
@apeltzer
Copy link
Member

apeltzer commented Dec 5, 2019

No I think this is fine 👍

@FriederikeHanssen FriederikeHanssen deleted the fix_typo branch December 5, 2019 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeltzer apeltzer apeltzer approved these changes

@matrulda matrulda matrulda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FriederikeHanssen @matrulda @apeltzer