Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json schema does not validate --tools and --skip_tools #892

Closed
maxulysse opened this issue Dec 11, 2022 · 5 comments
Closed

json schema does not validate --tools and --skip_tools #892

maxulysse opened this issue Dec 11, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@maxulysse
Copy link
Member

Description of the bug

nextflow run nf-core/sarek --profile test,docker --tools strelka2

should fail, but isn't

Command used and terminal output

No response

Relevant files

No response

System information

No response

@maxulysse maxulysse added the bug Something isn't working label Dec 11, 2022
@asp8200
Copy link
Contributor

asp8200 commented Dec 11, 2022

I confirm the error. A cmd like

nextflow run nf-core/sarek -r 3.1.1 -profile test,singularity --tools foo --skip_tools bar

doesn't cause the pipeline to an early exit, instead:

Main options
  [...]
  tools                     : foo
  skip_tools                : bar

@maxulysse
Copy link
Member Author

Do you think we can tests for failure in pytest?
I realize there are many expected failures that we should test...
Looking forward to test all that in nf-test

@FriederikeHanssen
Copy link
Contributor

weird, do you know why? I thought everything is validated by default....

@maxulysse
Copy link
Member Author

And I'm pretty sure this used to work

@asp8200
Copy link
Contributor

asp8200 commented Dec 12, 2022

And I'm pretty sure this used to work

I - incidentally - tested it on Sarek 2.7, and it worked there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants