Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tiddit #10

Merged
merged 12 commits into from
Aug 7, 2019
Merged

Add Tiddit #10

merged 12 commits into from
Aug 7, 2019

Conversation

maxulysse
Copy link
Member

@maxulysse maxulysse commented May 22, 2019

  • adding TIDDIT in Sarek main container
  • adding process for TIDDIT in main.nf

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

@maxulysse
Copy link
Member Author

I just saw @J35P312 after lunch to talk about integrating TIDDIT into Sarek, as planned it should be easy.

But I do have an issue with the current release

≻docker run nfcore/sarek:dev ls -lA /opt/conda/envs/nf-core-sarek-2.5dev/share/tiddit-2.6.0-0/bin  
ls: cannot access '/opt/conda/envs/nf-core-sarek-2.5dev/share/tiddit-2.6.0-0/bin': No such file or directory

the bin directory doesn't seem to exist:
https://github.com/bioconda/bioconda-recipes/blob/807d1908c7b86c51ea318bac3467888df93d5e99/recipes/tiddit/build.sh#L17

But I can see that the new release should arrive soon on bioconda: bioconda/bioconda-recipes#15498 thanks to @epruesse
So I'll check it out

@maxulysse maxulysse marked this pull request as ready for review August 6, 2019 10:45
@maxulysse maxulysse requested review from szilvajuhos and a team August 6, 2019 10:47
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@maxulysse maxulysse merged commit d0f03fe into nf-core:dev Aug 7, 2019
@maxulysse maxulysse deleted the TIDDIT branch August 7, 2019 08:41
Copy link
Contributor

@szilvajuhos szilvajuhos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants