Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: automatic restart from step #1062

Merged
merged 2 commits into from
Jun 2, 2023
Merged

FIX: automatic restart from step #1062

merged 2 commits into from
Jun 2, 2023

Conversation

maxulysse
Copy link
Member

@maxulysse maxulysse commented Jun 2, 2023 •
edited
Loading

working again
why are we not testing that?

@github-actions
Copy link

github-actions bot commented Jun 2, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 0a7b08d

+| ✅ 152 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-06-02 13:22:44

@FriederikeHanssen
Copy link
Contributor

couldn't figure out how to make a test at that time, results folder should be there with the files to then be picked up. Can you fake it by providing a github folder?. Tested manually excessively though

@maxulysse
Copy link
Member Author

couldn't figure out how to make a test at that time, results folder should be there with the files to then be picked up. Can you fake it by providing a github folder?. Tested manually excessively though

I think we had that test at some point, when we had consecutive runs

@maxulysse maxulysse merged commit 933bddb into nf-core:dev Jun 2, 2023
@maxulysse maxulysse deleted the restart branch June 2, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @FriederikeHanssen