Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linting #107

Merged
merged 12 commits into from
Jan 30, 2020
Merged

Fix linting #107

merged 12 commits into from
Jan 30, 2020

Conversation

maxulysse
Copy link
Member

  • Fix linting
  • switch params to snake_case
  • handle deprecated param
  • handle removed param
  • update docs

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@maxulysse maxulysse self-assigned this Jan 30, 2020
@maxulysse maxulysse requested a review from a team January 30, 2020 12:16
drpatelh
drpatelh approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@maxulysse maxulysse merged commit 2b306db into nf-core:dev Jan 30, 2020
@maxulysse maxulysse deleted the lint branch January 30, 2020 12:32
@drpatelh
Copy link
Member

The only danger in linting against nf-core/tools:dev is that something else might change there that could break the linting...

@maxulysse
Copy link
Member Author

I'll make another PR to fix it, but currently linting is not working, so I have no other choice

@maxulysse maxulysse mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drpatelh drpatelh drpatelh approved these changes

Assignees

@maxulysse maxulysse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @drpatelh