Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: patch more modules #1082

Merged
merged 6 commits into from
Jun 7, 2023
Merged

FIX: patch more modules #1082

merged 6 commits into from
Jun 7, 2023

Conversation

maxulysse
Copy link
Member

all aboard quay.io

@maxulysse maxulysse mentioned this pull request Jun 7, 2023
Merged
5 tasks
@maxulysse
Copy link
Member Author

merge conflicts are solved, but github is down

@github-actions
Copy link

github-actions bot commented Jun 7, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 63220d2

+| ✅ 152 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-06-07 20:03:36

FriederikeHanssen
FriederikeHanssen approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry still not quite gotten the container path logic, but docker hub will be detected even though we set quay as default?

modules/nf-core/gatk4/baserecalibratorspark/main.nf Show resolved Hide resolved
@maxulysse
Copy link
Member Author

Sorry still not quite gotten the container path logic, but docker hub will be detected even though we set quay as default?

No, no the full URI for docker works, but if we mirror docker.io containers on quay.io, then with all containers on the same registry, it's easier to change for all

@FriederikeHanssen
Copy link
Contributor

FriederikeHanssen commented Jun 7, 2023 •
edited
Loading

Thanks, yeah afterwards I saw Harshil's pr about moving all containers to quay. Makes all perfect sense now

@maxulysse maxulysse mentioned this pull request Jun 7, 2023
Closed
@maxulysse maxulysse merged commit 5da0b66 into nf-core:dev Jun 7, 2023
@maxulysse maxulysse deleted the patch_more_modules branch February 19, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @FriederikeHanssen