Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant index computation for MD & version for MD Spark #1101

Merged
merged 7 commits into from
Jun 14, 2023
Merged

Remove redundant index computation for MD & version for MD Spark #1101

merged 7 commits into from
Jun 14, 2023

Conversation

FriederikeHanssen
Copy link
Contributor

Pending nf-core/modules#3521

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@maxulysse maxulysse mentioned this pull request Jun 13, 2023
Merged
10 tasks
@github-actions
Copy link

github-actions bot commented Jun 14, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 8be49d9

+| ✅ 153 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-06-14 07:08:48

FriederikeHanssen
FriederikeHanssen commented Jun 14, 2023
View reviewed changes
modules.json Outdated
"git_sha": "911696ea0b62df80e900ef244d7867d177971f73",
"git_sha": "83ddd598664e16f74e0b5c728e9f81285c37e893",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#nf-core/tools#2014

FriederikeHanssen
FriederikeHanssen commented Jun 14, 2023
View reviewed changes
modules.json Outdated Show resolved Hide resolved
@FriederikeHanssen FriederikeHanssen marked this pull request as ready for review June 14, 2023 06:42
@FriederikeHanssen
Copy link
Contributor Author

@nf-core-bot fix linting pleeeease

maxulysse
maxulysse approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

subworkflows/local/bam_markduplicates/main.nf Show resolved Hide resolved
@maxulysse maxulysse merged commit 8306a79 into nf-core:dev Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FriederikeHanssen @maxulysse @nf-core-bot