Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update public_aws_ecr profile and add test #1113

Closed
wants to merge 4 commits into from
Closed

Update public_aws_ecr profile and add test #1113

wants to merge 4 commits into from

Conversation

adamrtalbot
Copy link
Contributor

Changes:

  • Update public_aws_ecr profile to use mulled container
  • Add test for public_aws_ecr profile to "default"

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@adamrtalbot
Update public_aws_ecr profile and add test
c85802d 
Changes:
 - Update public_aws_ecr profile to use mulled container
 - Add test for public_aws_ecr profile to "default"
@adamrtalbot adamrtalbot requested a review from maxulysse as a code owner June 15, 2023 16:07
@maxulysse
Copy link
Member

tags need to be added there: https://github.com/nf-core/sarek/blob/dev/tests/config/tags.yml

@maxulysse
Copy link
Member

and I feel we should be doing more than just profile test

@github-actions
Copy link

github-actions bot commented Jun 15, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 500d361

+| ✅ 154 tests passed       |+
#| ❔   9 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-06-15 17:10:00

@adamrtalbot
Copy link
Contributor Author

and I feel we should be doing more than just profile test

Agreed but I don't want to go too mad. Got a list of "core" tests I could use?

@maxulysse maxulysse mentioned this pull request Jun 16, 2023
Closed
@maxulysse
Copy link
Member

closed in favor of #1118

@maxulysse maxulysse closed this Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse Awaiting requested review from maxulysse maxulysse is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamrtalbot @maxulysse