Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More sensible default for use_annotation_cache_keys #1196

Merged
merged 1 commit into from
Aug 30, 2023
Merged

More sensible default for use_annotation_cache_keys #1196

merged 1 commit into from
Aug 30, 2023

Conversation

maxulysse
Copy link
Member

Will give more time to fully launch said functionnality

@github-actions
Copy link

github-actions bot commented Aug 30, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 66477cd

+| ✅ 151 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-08-30 07:27:05

@asp8200
Copy link
Contributor

asp8200 commented Aug 30, 2023

Do we have a proper or "reasonable" test of the annotation functionality where use_annotation_cache_keys is false? (I noticed that you are setting use_annotation_cache_keys to true in test_full.config and test_full_germline.config.)

@maxulysse
Copy link
Member Author

Do we have a proper or "reasonable" test of the annotation functionality where use_annotation_cache_keys is false? (I noticed that you are setting use_annotation_cache_keys to true in test_full.config and test_full_germline.config.)

That would be doing locally with local cache, which is actually what we actually have in sarek since like for ever.
I just don't want to break that functionality for now until I have proper docs for annotation_cache

asp8200
asp8200 approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@asp8200 asp8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what that button does 🤔

@maxulysse maxulysse merged commit 0c77289 into nf-core:dev Aug 30, 2023
19 checks passed
@maxulysse maxulysse deleted the annotation_cache_keys branch August 30, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asp8200 asp8200 asp8200 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @asp8200