Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use matrix for all aws tests GHA #1212

Merged
merged 4 commits into from
Sep 7, 2023
Merged

Use matrix for all aws tests GHA #1212

merged 4 commits into from
Sep 7, 2023

Conversation

adamrtalbot
Copy link
Contributor

@adamrtalbot adamrtalbot commented Sep 6, 2023 •
edited
Loading

Uses a Github Actions matrix to control which AWS test occurs. As part of this it becomes simpler code with less repeating.

The main downside is Github actions will run the job but skip all steps within, which will occupy workers and isn't obvious in the interface. However, this is OK given these tests are fairly infrequent:

Skipped (note steps are skipped):
image

Ran:
image

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@adamrtalbot adamrtalbot mentioned this pull request Sep 6, 2023
Closed
10 tasks
@github-actions
Copy link

github-actions bot commented Sep 6, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit ebd35c5

+| ✅ 140 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-09-07 09:03:51

@adamrtalbot adamrtalbot mentioned this pull request Sep 6, 2023
Merged
10 tasks
adamrtalbot
adamrtalbot commented Sep 7, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@maxulysse
Copy link
Member

Can we have something similar for the megatests as well?

@adamrtalbot
Copy link
Contributor Author

Can we have something similar for the megatests as well?

...I thought these were the megatests?

@maxulysse
Copy link
Member

Can we have something similar for the megatests as well?

...I thought these were the megatests?

🤦 Yeah, I got tricked by the filename...

@maxulysse maxulysse changed the title Use matrix for awstest github action Use matrix for all aws tests GHA Sep 7, 2023
@maxulysse maxulysse merged commit d660ab6 into dev Sep 7, 2023
11 checks passed
@maxulysse maxulysse deleted the aws_test_via_matrix branch September 7, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamrtalbot @maxulysse