Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Important! Template update for nf-core/tools v2.11 #1360

Merged
merged 7 commits into from
Dec 20, 2023
Merged

Important! Template update for nf-core/tools v2.11 #1360

merged 7 commits into from
Dec 20, 2023

Conversation

nf-core-bot
Copy link
Member

Version 2.11 of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.

Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the nf-core-template-merge-2.11 branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.

For instructions on how to merge this PR, please see https://nf-co.re/docs/contributing/sync/.

For more information about this release of nf-core/tools, please see the v2.11 release page.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 20, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit ab9ade1

+| ✅ 148 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in WorkflowSarek.groovy: Optionally add in-text citation tools to this list.

❔ Tests ignored:

  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: conf/modules.config
  • files_unchanged - File ignored due to lint config: assets/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_ci - actions_ci
  • template_strings - template_strings

✅ Tests passed:

Run details

  • nf-core/tools version 2.11
  • Run at 2023-12-20 08:49:20

FriederikeHanssen
FriederikeHanssen reviewed Dec 20, 2023
View reviewed changes
nextflow.config
@@ -190,6 +192,7 @@ profiles {
docker.userEmulation = { params.use_gatk_spark ? false : true }.call()
podman.enabled = false
shifter.enabled = false
docker.runOptions = '-u $(id -u):$(id -g)'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting anxious about any spark related issues :D

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit too, we'd need to try this out properly, I'll make an issue

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1362

@maxulysse maxulysse mentioned this pull request Dec 20, 2023
Open
@maxulysse maxulysse merged commit 490c68c into dev Dec 20, 2023
23 checks passed
@maxulysse maxulysse deleted the nf-core-template-merge-2.11 branch December 20, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

@maxulysse maxulysse Awaiting requested review from maxulysse maxulysse is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nf-core-bot @maxulysse @FriederikeHanssen