Further improvments for minimal settings #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxulysse
changed the title
ggabernet
approved these changes
Apr 23, 2020
| @@ -25,8 +25,10 @@ Piellorieppe is one of the main massif in the Sarek National Park. | |||
| - [#175](https://github.com/nf-core/sarek/pull/175) - Add `Sentieon` documentation | |||
| - [#176](https://github.com/nf-core/sarek/pull/176) - Add empty `custom` genome in `genomes.config` to allow genomes that are not in `AWS iGenomes` | |||
| - [#179](https://github.com/nf-core/sarek/pull/179) - Add `FreeBayes` germline variant calling | |||
| - [#180](https://github.com/nf-core/sarek/pull/180) - Now saving Mapped Bams (and creating TSV) in minimal setting | |||
| - [#180](https://github.com/nf-core/sarek/pull/180) - Now saving Mapped BAMs (and creating TSV) in minimal setting | |||
There was a problem hiding this comment.
Just out of curiousity, what is the minimal setting?
There was a problem hiding this comment.
Just a fasta file for the reference genome.
We have this user working on some Bees, so there is a reference genome, but nothing else, no know variants or such.
So the plan is actually to use sarek to do some variant calling to get some known variants (SNPs) from only duplicates marked files and then use these variants within sarek to be able to finally do some recalibration.
There was a problem hiding this comment.
|
GitHub seems to have some issue, so I'll wait for the tests to be OK to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nf-core/sarek pull request
Many thanks for contributing to nf-core/sarek!
Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).
PR checklist
nextflow run . -profile test,docker).nf-core lint .).docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: CONTRIBUTING.md