Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update GATK and fix Freebayes-Mutect2 channels issue #214

Merged
merged 2 commits into from
Jun 5, 2020

Conversation

maxulysse
Copy link
Member

nf-core/sarek pull request

Close and fix #200 #209 #210

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@maxulysse maxulysse requested review from a team and FriederikeHanssen June 5, 2020 07:22
@maxulysse
Copy link
Member Author

Tested on our cluster, and the Freebayes Mutect2 channel collision is now gone.
I think it was introduced when @szilvajuhos and I updated Mutect2 with the PON and the filtering.
Sorry all for the inconvenience.

And thanks to @jfnavarro for founding this bug in the first place.

I know it's bad practices, and I should have addressed that in separate PRs, but I also fixed the two issues recently raised by @FriederikeHanssen

So thanks a lot for finding out about that as well.

@maxulysse maxulysse merged commit 77073c5 into nf-core:dev Jun 5, 2020
@maxulysse maxulysse deleted the Mutect2Freebayes branch June 5, 2020 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants