Add ApplyBQSR, SamtoolStats, BamQC #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxulysse
reviewed
Jul 31, 2020
Comment on lines
11
to
14
| // samtools index ${idSample}.bam | ||
|
|
||
| // samtools index ${idSample}.recal.bam | ||
|
|
There was a problem hiding this comment.
Suggested change
| // samtools index ${idSample}.bam | |
| // samtools index ${idSample}.recal.bam |
maxulysse
reviewed
Jul 31, 2020
modules/local/process/merge_bam.nf
Outdated
| @@ -4,14 +4,16 @@ process MERGE_BAM { | |||
| tag "${meta.id}" | |||
|
|
|||
| input: | |||
| tuple val(meta), path(bam), path(bai) | |||
| tuple val(meta), path(bam)//, path(bai) optional: true | |||
There was a problem hiding this comment.
optional: true for the input?
There was a problem hiding this comment.
This is void now, sorry still working on this.
|
@maxulysse maybe don't merge quite yet. I have a hunch about the problem with BamQC, but am too tired now. Hopefully, I can sit down in the morning with it :) |
|
Will merge, and we figure out the bamqc issues in the next PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nf-core/sarek pull request
Many thanks for contributing to nf-core/sarek!
Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).
PR checklist
nextflow run . -profile test,docker).nf-core lint .).docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: CONTRIBUTING.md