Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GHA issues #310

Merged
merged 5 commits into from
Dec 4, 2020
Merged

Fix GHA issues #310

merged 5 commits into from
Dec 4, 2020

Conversation

apeltzer
Copy link
Member

Fix first bit of november 16 issues.

nf-core/sarek pull request

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

@apeltzer apeltzer marked this pull request as ready for review November 27, 2020 08:49
@apeltzer apeltzer requested a review from maxulysse as a code owner November 27, 2020 08:49
@apeltzer apeltzer requested a review from a team November 27, 2020 08:49
@apeltzer
Copy link
Member Author

This should help for new PRs opened to at least have the CI run through fine :-)

@maxulysse
Copy link
Member

Thanks @apeltzer

@maxulysse maxulysse merged commit f28eb68 into dev Dec 4, 2020
@maxulysse
Copy link
Member

@FriederikeHanssen we'll need to push that to dsl2 too

@apeltzer
Copy link
Member Author

apeltzer commented Dec 4, 2020

Guess this should've been covered by template sinc

@maxulysse maxulysse deleted the fix-gha-nov16 branch December 4, 2020 09:50
@maxulysse
Copy link
Member

I think I'm late for a couple of template update...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apeltzer @maxulysse