-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add complete conda env to faster solving #323
Conversation
@apeltzer any idea on how to simplify the |
I've recently read something about removing detailed dependencies wherever possible as this makes the solving faster. E.g. if you have samtools which depends on htslib, then don't explicitly import htslib and let the samtools recipe take care of finding htslib and installing it for you. I'd try to only have the "major" packages in the environment.yaml and then try to find out whether this builds in the end then ...? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its quite a long list now - really focus on the major ones and hope that it resolves it properly. Also I heard mixed experiences with having R packages that are not from conda-forge + bioconda but also from other R channels to be largely incompatible with these :-(
I actually have no idea, I just copied the environment that was successful in mamba here. |
Ok, so I'll try to remove as much as possible and see if it still works as well. |
Yes, I think that would make sense 👍🏼 Otherwise updating this will be extremely difficult :-( |
I don't plan on updating this ever actually. |
Much better :-) |
Definitively better, but in the end, I have no idea why it's working when the previous version was not. |
Mistery conda ;-) |
nf-core/sarek pull request
Many thanks for contributing to nf-core/sarek!
Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).
PR checklist
nextflow run . -profile test,docker
).nf-core lint .
).docs
is updatedCHANGELOG.md
is updatedREADME.md
is updatedLearn more about contributing: CONTRIBUTING.md