Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add complete conda env to faster solving #323

Merged
merged 3 commits into from
Jan 19, 2021
Merged

Conversation

maxulysse
Copy link
Member

nf-core/sarek pull request

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@maxulysse maxulysse requested a review from apeltzer January 19, 2021 12:23
@maxulysse
Copy link
Member Author

@apeltzer any idea on how to simplify the environment.yml file?

@apeltzer
Copy link
Member

I've recently read something about removing detailed dependencies wherever possible as this makes the solving faster. E.g. if you have samtools which depends on htslib, then don't explicitly import htslib and let the samtools recipe take care of finding htslib and installing it for you.

I'd try to only have the "major" packages in the environment.yaml and then try to find out whether this builds in the end then ...?

Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its quite a long list now - really focus on the major ones and hope that it resolves it properly. Also I heard mixed experiences with having R packages that are not from conda-forge + bioconda but also from other R channels to be largely incompatible with these :-(

environment.yml Outdated Show resolved Hide resolved
environment.yml Outdated Show resolved Hide resolved
environment.yml Outdated Show resolved Hide resolved
@maxulysse
Copy link
Member Author

I actually have no idea, I just copied the environment that was successful in mamba here.
I was happy that it worked already

@maxulysse
Copy link
Member Author

Ok, so I'll try to remove as much as possible and see if it still works as well.
Thanks for the tips

@apeltzer
Copy link
Member

Yes, I think that would make sense 👍🏼 Otherwise updating this will be extremely difficult :-(

@maxulysse
Copy link
Member Author

Yes, I think that would make sense 👍🏼 Otherwise updating this will be extremely difficult :-(

I don't plan on updating this ever actually.
Plan is to get rid of it once 2.7 is done and go full dsl2 for 3.0

@maxulysse maxulysse merged commit 347e29f into nf-core:dev Jan 19, 2021
@maxulysse maxulysse deleted the conda branch January 19, 2021 14:18
@apeltzer
Copy link
Member

Much better :-)

@maxulysse
Copy link
Member Author

Definitively better, but in the end, I have no idea why it's working when the previous version was not.

@apeltzer
Copy link
Member

Mistery conda ;-)

@maxulysse maxulysse mentioned this pull request Jan 24, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants