Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update reference files #34

Merged
merged 5 commits into from
Sep 13, 2019
Merged

update reference files #34

merged 5 commits into from
Sep 13, 2019

Conversation

maxulysse
Copy link
Member

  • update reference files
    • add ChrDir and ChrLength for ControlFREEC

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/sarek/tree/master/.github/CONTRIBUTING.md

@maxulysse maxulysse self-assigned this Sep 10, 2019
@maxulysse maxulysse requested review from a team and szilvajuhos September 13, 2019 08:31
apeltzer
apeltzer approved these changes Sep 13, 2019
View reviewed changes
Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@apeltzer apeltzer merged commit c0a86e2 into nf-core:dev Sep 13, 2019
@maxulysse maxulysse deleted the AWS-iGenomes branch September 13, 2019 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeltzer apeltzer apeltzer approved these changes

@szilvajuhos szilvajuhos Awaiting requested review from szilvajuhos

Assignees

@maxulysse maxulysse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @apeltzer