-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pytest workflow for CI #370
Conversation
Dsl2 subworkflow tests
@emiller88 I see what you meant by this where the real magic starts... |
Co-authored-by: Edmund Miller <edmund.a.miller@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this is awesome 🤩 ❤️ . The linting i not passing yet:
[✗] 21 Tests Failed │
├──────────────────────────────────────────────────────────────────────────────┤
│ files_exist: File not found: lib/nfcore_external_java_deps.jar │
│ files_exist: File not found: lib/NfcoreSchema.groovy │
│ nextflow_config: Config variable not found: params.show_hidden_params │
│ nextflow_config: Config variable not found: params.schema_ignore_params │
│ nextflow_config: Config variable (incorrectly) found: params.name │
│ files_unchanged: CODE_OF_CONDUCT.md does not match the template │
│ files_unchanged: .github/.dockstore.yml does not match the template │
│ files_unchanged: .github/CONTRIBUTING.md does not match the template │
│ files_unchanged: .github/ISSUE_TEMPLATE/bug_report.md does not match the te… │
│ files_unchanged: .github/ISSUE_TEMPLATE/feature_request.md does not match t… │
│ files_unchanged: .github/markdownlint.yml does not match the template │
│ files_unchanged: .github/PULL_REQUEST_TEMPLATE.md does not match the templa… │
│ files_unchanged: .github/workflows/branch.yml does not match the template │
│ files_unchanged: .github/workflows/linting.yml does not match the template │
│ files_unchanged: assets/nf-core-sarek_logo.png does not match the template │
│ files_unchanged: bin/markdown_to_html.py does not match the template │
│ files_unchanged: docs/images/nf-core-sarek_logo.png does not match the temp… │
│ files_unchanged: .gitignore does not match the template │
│ files_unchanged: assets/multiqc_config.yaml does not match the template │
│ actions_ci: '.github/workflows/ci.yml' is not triggered on expected events │
│ actions_ci: Minimum NF version in '.github/workflows/ci.yml' different to p… │
Did you expect that?
And one other idea: maybe add a short readme on how to add new tests for new developers, or is it the exact same as with the modules-repo?
Yeah, nf-core lint would be another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK great. Then maybe let's add a README in a seperate PR, like a short Step-by-step or so.
I'm guessing a step by step should even go in another repo. |
Following @emiller88 lead on improving CI
PR checklist
scrape_software_versions.py
nf-core lint .
).nextflow run . -profile test,docker
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).