Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pytest workflow for CI #370

Merged
merged 15 commits into from
May 19, 2021
Merged

Add pytest workflow for CI #370

merged 15 commits into from
May 19, 2021

Conversation

maxulysse
Copy link
Member

Following @emiller88 lead on improving CI

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@maxulysse
Copy link
Member Author

@emiller88 I see what you meant by this where the real magic starts...
🤯

@maxulysse maxulysse marked this pull request as ready for review May 12, 2021 08:27
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is awesome 🤩 ❤️ . The linting i not passing yet:

[✗] 21 Tests Failed                                                          │
├──────────────────────────────────────────────────────────────────────────────┤
│ files_exist: File not found: lib/nfcore_external_java_deps.jar               │
│ files_exist: File not found: lib/NfcoreSchema.groovy                         │
│ nextflow_config: Config variable not found: params.show_hidden_params        │
│ nextflow_config: Config variable not found: params.schema_ignore_params      │
│ nextflow_config: Config variable (incorrectly) found: params.name            │
│ files_unchanged: CODE_OF_CONDUCT.md does not match the template              │
│ files_unchanged: .github/.dockstore.yml does not match the template          │
│ files_unchanged: .github/CONTRIBUTING.md does not match the template         │
│ files_unchanged: .github/ISSUE_TEMPLATE/bug_report.md does not match the te… │
│ files_unchanged: .github/ISSUE_TEMPLATE/feature_request.md does not match t… │
│ files_unchanged: .github/markdownlint.yml does not match the template        │
│ files_unchanged: .github/PULL_REQUEST_TEMPLATE.md does not match the templa… │
│ files_unchanged: .github/workflows/branch.yml does not match the template    │
│ files_unchanged: .github/workflows/linting.yml does not match the template   │
│ files_unchanged: assets/nf-core-sarek_logo.png does not match the template   │
│ files_unchanged: bin/markdown_to_html.py does not match the template         │
│ files_unchanged: docs/images/nf-core-sarek_logo.png does not match the temp… │
│ files_unchanged: .gitignore does not match the template                      │
│ files_unchanged: assets/multiqc_config.yaml does not match the template      │
│ actions_ci: '.github/workflows/ci.yml' is not triggered on expected events   │
│ actions_ci: Minimum NF version in '.github/workflows/ci.yml' different to p… │

Did you expect that?

And one other idea: maybe add a short readme on how to add new tests for new developers, or is it the exact same as with the modules-repo?

@maxulysse
Copy link
Member Author

Yeah, nf-core lint would be another PR.
Same as for modules. but yeah a README somewhere might be nice

Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK great. Then maybe let's add a README in a seperate PR, like a short Step-by-step or so.

@maxulysse
Copy link
Member Author

OK great. Then maybe let's add a README in a seperate PR, like a short Step-by-step or so.

I'm guessing a step by step should even go in another repo.
It's not sarek specific

@maxulysse maxulysse merged commit 13f61c1 into nf-core:dsl2 May 19, 2021
@maxulysse maxulysse deleted the dsl2_tests branch May 19, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants