Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new version of joint germline subworkflow. Early WIP #547

Closed
wants to merge 4 commits into from

Conversation

GCJMackenzie
Copy link

PR checklist

  • This comment contains a description of changes (with reason). Adds the new version of the joint germline subworkflow, used for adding gvcf files to a genomicsdb workspace, then perform joint variant calling using genotypeGVCFs. New version separates this step from haplotypecaller and the vqsr process. Whilst the code is functional with in Atholl, there is some work to do to bring it in line with Sarek guidelines. It is not ready for review currently. Adding PR now for tracking purposes. Linked to issue Enable joint variant calling for germline samples #75.
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@GCJMackenzie GCJMackenzie added enhancement New feature or request gatk labels May 13, 2022
@GCJMackenzie GCJMackenzie requested a review from maxulysse as a code owner May 13, 2022 13:55
@GCJMackenzie GCJMackenzie self-assigned this May 13, 2022
@maxulysse maxulysse marked this pull request as draft June 2, 2022 09:03
@maxulysse
Copy link
Member

I marked this as a draft as it's a WIP

@maxulysse
Copy link
Member

Closing this one in favor of #595

@maxulysse maxulysse closed this Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants