Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qc on speed: FastP and Mosdepth as drop-in replacement for Trimgalore/Seqkit & Deeptools/qualimap #596

Merged
merged 38 commits into from
Jun 24, 2022
Merged

Qc on speed: FastP and Mosdepth as drop-in replacement for Trimgalore/Seqkit & Deeptools/qualimap #596

merged 38 commits into from
Jun 24, 2022

Conversation

FriederikeHanssen
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen commented Jun 19, 2022 •
edited
Loading

Close #508

cc #95

TODO:

  • Update Fastp module to not have .trim in the output (confusing when it is just used for splitting
  • UMI subworkflow: incooporation into FastP?
  • Add test for trimming
  • Update subway map
  • Update docs
  • Make sure MultiQC has all plots
  • Document new parameters, update modules.config

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Jun 19, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 5851733

+| ✅ 145 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-06-24 16:07:22

FriederikeHanssen
FriederikeHanssen commented Jun 24, 2022
View reviewed changes
conf/modules.config Outdated
params.split_fastq > 0 ? "--split_by_lines ${params.split_fastq * 4}" : "",

// For trimgalore also auto detection was used
//params.adapter_R1 ? "--adapter_sequence ${params.adapter_R1}" : "", //normally not needed
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we provide the additonal parameter for setting specific adapter sequences? Wasn't supported before, but trimgalore guessed the adapter (same here at the moment by default) @maxulysse

@FriederikeHanssen FriederikeHanssen marked this pull request as ready for review June 24, 2022 13:13
ggabernet
ggabernet reviewed Jun 24, 2022
View reviewed changes
Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some comments, but otherwise looks good!

conf/modules.config Show resolved Hide resolved
tests/test_recalibrate.yml Show resolved Hide resolved
workflows/sarek.nf Show resolved Hide resolved
workflows/sarek.nf Show resolved Hide resolved
ggabernet
ggabernet approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@FriederikeHanssen FriederikeHanssen merged commit fe25216 into nf-core:dev Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggabernet ggabernet ggabernet approved these changes

@maxulysse maxulysse Awaiting requested review from maxulysse maxulysse is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FriederikeHanssen @ggabernet