Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal genomes possibilities #60

Merged
merged 27 commits into from
Dec 6, 2019
Merged

Conversation

maxulysse
Copy link
Member

  • Add no_intervals params
  • Add automatic generation of intervals file with BuildIntervals process
  • Add minimal support for minimal genome (only fasta, or fasta + knownIndels)
  • Add new processes (IndexBamFile, IndexBamRecal) to deal with optional usage of interval files and minimal genome
  • Add tests for minimal genome usage
  • Add new minimal genomes (AGPv3, BDGP6, CHIMP2.1.4, CanFam3.1, EB1, EB2, EF2, EquCab2, GRCz10, Galgal4, Gm01, IRGSP-1.0, Mmul_1, R64-1-1, Rnor_6.0, Sbi1, Sscrofa10.2, TAIR10, UMD3.1, WBcel235, bosTau8, canFam3, ce10, danRer10, dm6, equCab2, galGal4, hg19, hg38, mm10, panTro4, rn6, sacCer3, susScr3) to igenomes.config
  • Some process (BaseRecalibrator, ApplyBQSR, Mpileup) have now optional usage of interval files
  • Update comments

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: guidelines

@maxulysse maxulysse requested a review from a team November 4, 2019 16:11
@maxulysse maxulysse self-assigned this Nov 4, 2019
@maxulysse maxulysse added the enhancement New feature or request label Nov 4, 2019
Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing stuff @maxulysse !

scripts/run_tests.sh Outdated Show resolved Hide resolved
@maxulysse
Copy link
Member Author

Needs docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants