Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comments merged on the 3.0 PR back to dev #664

Merged
merged 41 commits into from
Jul 20, 2022

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

maxulysse and others added 30 commits May 13, 2021 16:40
…e/issue-555/caching-bugfix

Fix `MapReads` caching bug
Co-authored-by: Mahesh Binzer-Panchal <mahesh.binzer-panchal@nbis.se>
Co-authored-by: Alexander Peltzer <apeltzer@users.noreply.github.com>
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
FriederikeHanssen and others added 6 commits July 19, 2022 19:59
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
Co-authored-by: WackerO <43847497+WackerO@users.noreply.github.com>
Co-authored-by: WackerO <43847497+WackerO@users.noreply.github.com>
@maxulysse
Copy link
Member Author

Do not merge this one, let's keep it, until we're ready to merge #631
Merge this one first, sync #631 and merge, and release

docs/usage.md Outdated Show resolved Hide resolved
Copy link
Contributor

@SusiJo SusiJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving, just the usage.md needs the duplicate sections removed

@github-actions
Copy link

github-actions bot commented Jul 20, 2022

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit fc09504

+| ✅ 146 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.
  • schema_description - No description provided in schema for parameter: ascat_ploidy

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-07-20 12:22:00

docs/usage.md Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
Co-authored-by: Anders Sune Pedersen <37172585+asp8200@users.noreply.github.com>
@maxulysse maxulysse merged commit 467b2e6 into nf-core:dev Jul 20, 2022
@maxulysse maxulysse deleted the dev_3.0_PR branch July 20, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants