Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CODEOWNERS file #68

Merged
merged 1 commit into from
Dec 12, 2019
Merged

add CODEOWNERS file #68

merged 1 commit into from
Dec 12, 2019

Conversation

maxulysse
Copy link
Member

  • add CODEOWNERS file to TEMPLATE branch

Many thanks to contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: guidelines

@maxulysse maxulysse requested a review from a team November 18, 2019 15:01
@maxulysse maxulysse self-assigned this Nov 18, 2019
@maxulysse maxulysse added the docs label Nov 18, 2019
@maxulysse
Copy link
Member Author

I'm guessing template update should fix tests

@ewels
Copy link
Member

ewels commented Dec 10, 2019

Why does this need to go in to the TEMPLATE branch?

@maxulysse
Copy link
Member Author

Because I think I should be responsible for code in this branch as well

@ewels
Copy link
Member

ewels commented Dec 12, 2019

Fair enough. I guess it shouldn’t mess with template syncing.. 🤔

@maxulysse maxulysse merged commit b46c299 into nf-core:TEMPLATE Dec 12, 2019
@maxulysse maxulysse deleted the TEMPLATE branch December 12, 2019 13:22
@ewels
Copy link
Member

ewels commented Dec 12, 2019

I wonder if this should go in to the tools template also? And use the author info?

@maxulysse
Copy link
Member Author

I do agree, but I think we removed the GitHub handle from the template, to simplify the creation of a new pipeline.
Could be worth it to had it back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants