Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sourmash as a profiler (or similar) #112

Open
jfy133 opened this issue Aug 29, 2022 · 9 comments
Open

Add sourmash as a profiler (or similar) #112

jfy133 opened this issue Aug 29, 2022 · 9 comments
Labels
enhancement Improvement for existing functionality

Comments

@jfy133
Copy link
Member

jfy133 commented Aug 29, 2022

Description of feature

Example workflow: https://taylorreiter.github.io/2022-07-28-From-raw-metagenome-reads-to-phyloseq-taxonomy-table-using-sourmash-gather-and-sourmash-taxonomy/

@jfy133 jfy133 added the enhancement Improvement for existing functionality label Aug 29, 2022
@jfy133
Copy link
Member Author

jfy133 commented Aug 29, 2022

@jfy133 jfy133 added this to the 1.1 milestone Sep 6, 2022
@vmikk vmikk self-assigned this Oct 10, 2022
@vmikk vmikk moved this to Todo (Hackathon General) in nf-core Hackathon March 2023 Oct 10, 2022
@vmikk vmikk moved this from Todo (Hackathon General) to In Progress in nf-core Hackathon March 2023 Oct 10, 2022
@vmikk vmikk moved this from In Progress to Todo (Hackathon General) in nf-core Hackathon March 2023 Oct 10, 2022
@vmikk
Copy link
Member

vmikk commented Oct 10, 2022

Sourmash module PR from Taylor Reiter: nf-core/modules#2176
(not merged yet)

@vmikk
Copy link
Member

vmikk commented Oct 11, 2022

For taxonomy profiling, we need a new module sourmash/gather (nf-core/modules#2214)

@vmikk vmikk moved this from Todo (Hackathon General) to In Progress in nf-core Hackathon March 2023 Oct 11, 2022
@vmikk
Copy link
Member

vmikk commented Oct 12, 2022

sourmash/gather should be working now (nf-core/modules#2250).
Now it's the turn for the sourmash/taxonomy module.

@hkaspersen
Copy link
Contributor

Hello! I was wondering if you had a timeline for adding sourmash to Taxprofiler? I am very interested in trying it!

@jfy133
Copy link
Member Author

jfy133 commented Aug 2, 2023

@vmikk is this still possible on your end, or would you like someone else to take over?

@vmikk
Copy link
Member

vmikk commented Aug 2, 2023

Hello!
I'm heavily engaged with my day job at the moment and unfortunately, I can't dedicate the necessary time to this project now.
I apologize for any inconvenience caused by this delay.
If quick completion is required, it would probably be more efficient if someone else could step in for now.

However, I've registered for the upcoming hackathon in Barcelona with the hope that it could provide an opportunity for me to finalize this task. I'm optimistic that the focused environment and collective energy at the event will allow me to make significant progress on this.

@jfy133
Copy link
Member Author

jfy133 commented Aug 2, 2023

OK thanks for the update @vmikk ! We are about to release 1.1 anyway so I don't think sourmash will be fit in there in time.

If there are any taxprofiler devs in BCN maybe you can sit with them @vmikk and power through it! (I won't be there this year due to parental leave).

@jfy133
Copy link
Member Author

jfy133 commented Oct 22, 2024

@vmikk I've removed you for now as I guess you're still very busy. Feel free to pick this up at a future date if you get time again @:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement for existing functionality
Projects
No open projects
Status: Todo
Status: In progress
Status: In Progress
Development

No branches or pull requests

4 participants