Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modules lint to check git commit of modules #1114

Closed
KevinMenden opened this issue Jun 16, 2021 · 1 comment
Closed

Update modules lint to check git commit of modules #1114

KevinMenden opened this issue Jun 16, 2021 · 1 comment
Assignees
Labels
command line tools Anything to do with the cli interfaces
Milestone

Comments

@KevinMenden
Copy link
Contributor

Use the modules.json file to check whether the git commits (i.e. versions) of modules are the most recent ones and warn if not.

@ewels ewels added command line tools Anything to do with the cli interfaces DSL2 labels Jun 16, 2021
@KevinMenden KevinMenden self-assigned this Jun 23, 2021
@KevinMenden
Copy link
Contributor Author

KevinMenden commented Jun 23, 2021

Features to implement:

  • check if modules.json exists (--> files_exist of nf-core lint)
  • check that all nf-core modules have an entry in modules.json
  • warn if new commit versions are available
  • verify that the file content fits the commit message --> this can be done by the modules_changes lint test just by using the git_sha

@KevinMenden KevinMenden mentioned this issue Jun 23, 2021
4 tasks
@ewels ewels added this to the 1.15 milestone Jun 24, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command line tools Anything to do with the cli interfaces
Projects
None yet
Development

No branches or pull requests

2 participants