Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linting for biocontainers specified with the registry format introduced in tools v2.8 #2276

Closed
drpatelh opened this issue May 4, 2023 · 2 comments
Closed

Add linting for biocontainers specified with the registry format introduced in tools v2.8 #2276

drpatelh opened this issue May 4, 2023 · 2 comments
Labels
enhancement

Comments

@drpatelh
Copy link
Member

drpatelh commented May 4, 2023 •
edited
Loading

See Slack for details.
@ewels
Copy link
Member

ewels commented May 4, 2023

We fail linting when:
docker_img_name.startswith('quay.io/biocontainers') and not docker_img_name.startswith('quay.io/biocontainers/mulled-')

@adamrtalbot
Copy link
Contributor

Here

tools/nf_core/modules/lint/main_nf.py

Line 293 in 0912990

if l.startswith("biocontainers/"):

@adamrtalbot adamrtalbot mentioned this issue May 4, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ewels @adamrtalbot @drpatelh