Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint GitHub Actions files #795

Closed
ewels opened this issue Nov 24, 2020 · 2 comments
Closed

Lint GitHub Actions files #795

ewels opened this issue Nov 24, 2020 · 2 comments
Labels

Comments

@ewels
Copy link
Member

ewels commented Nov 24, 2020

I noticed the other day that the VSCode YAML linting tool uses JSON schema for specific YAML files if it recognises the file paths. Specifically, it validates GitHub Actions workflow files. This could be a really nice addition!

Here's the JSON Schema file for GitHub Actions: https://json.schemastore.org/github-action

We already have a bunch of code in nf-core/tools for handling JSON Schema, so should hopefully be fairly easy to also validate these files without adding any new dependencies.

@ewels ewels added the linting label Nov 24, 2020
@KevinMenden
Copy link
Contributor

Makes sense - will have a look at it 👍 👀

This was referenced Jan 5, 2021
@KevinMenden
Copy link
Contributor

Made a PR #820 to add this functionality, was actually pretty straightforward to do.

I Used the GitHub Workflows Schema: https://json.schemastore.org/github-workflow
The one posted by you is for actions.

@ewels ewels closed this as completed Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants