Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils.determine_base_dir is broken when nested configs exist #2862

Closed
awgymer opened this issue Mar 18, 2024 · 1 comment
Closed

utils.determine_base_dir is broken when nested configs exist #2862

awgymer opened this issue Mar 18, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@awgymer
Copy link
Contributor

awgymer commented Mar 18, 2024

Description of the bug

The utils.determine_base_dir method is actually broken but working erroneously under most circumstances.

The issue is discoverable when running nf-core modules commands in nested directories with .nf-core.yml.

Essentially the issue is:

  • current/supplied directory is never actually checked for a config file
  • this doesn't fail because when the code finds no configs in the directory tree it reverts back to the supplied directory as the base dir
  • this directory in most cases actually does have a config and so the code never alerts the user that it only found it by chance.

Fix by reverting to original line which checked presence of config in current/supplied dir before iterating the tree

Command used and terminal output

No response

System information

No response

@awgymer awgymer added the bug Something isn't working label Mar 18, 2024
@awgymer awgymer self-assigned this Mar 18, 2024
@awgymer
Copy link
Contributor Author

awgymer commented Mar 19, 2024

Fixed in #2863

@awgymer awgymer closed this as completed Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant