Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] after deleting assays they are still visible in the assay subtree #313

Closed
langeipk opened this issue Dec 11, 2024 · 6 comments
Closed
Assignees
Labels
Critical Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.

Comments

@langeipk
Copy link

OS and framework information (please complete the following information):

  • OS: [e.g. LINUX]

Describe the bug
when droping a assay they are still visible. When shutdown, start and reload the investigation they are gone. This is true for version 0.0.50. In version 0.0.51 the deletion does not work at all

@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Dec 11, 2024
@JonasLukasczyk
Copy link
Collaborator

Thank you for raising this issue. I investigated the problem and it looks to me like ARCtrl renamed the RemoveAssay and RemoveStudy functions. There seems to be something weird going on because during testing these functions exist, but on release they are missing, instead an ARC only has the functions RemoveAssayAsync and RemoveStudyAsync. Can you have a look @HLWeil (this seems critical)

@JonasLukasczyk JonasLukasczyk self-assigned this Dec 12, 2024
@JonasLukasczyk JonasLukasczyk added Critical Type: Bug Something is not working, and it is confirmed by maintainers to be a bug. and removed Status: Needs Triage This item is up for investigation. labels Dec 12, 2024
@JonasLukasczyk
Copy link
Collaborator

Downgrading ARCtrl to version 2.0.1 solves the issue.

@HLWeil
Copy link
Member

HLWeil commented Dec 12, 2024

Yes this is my fault for renaming existing functions between the releases:

  • RemoveAssay is now called GetAssayRemoveContracts
  • RemoveStudy is now called GetStudyRemoveContracts
  • RenameAssay is now called GetAssayRenameContracts
  • RenameStudy is now called GetStudyRenameContracts

@HLWeil
Copy link
Member

HLWeil commented Dec 12, 2024

RenameAssayAsync and such now also fulfill the Contracts, given node is installed.

@JonasLukasczyk
Copy link
Collaborator

Thank you, I will switch right away.

@JonasLukasczyk
Copy link
Collaborator

Fixed in v0.0.52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.
Projects
Status: Done
Development

No branches or pull requests

3 participants