Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should json writer only consider registered items? #229

Closed
HLWeil opened this issue Oct 10, 2023 · 1 comment · Fixed by #230
Closed

Should json writer only consider registered items? #229

HLWeil opened this issue Oct 10, 2023 · 1 comment · Fixed by #230
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.

Comments

@HLWeil
Copy link
Member

HLWeil commented Oct 10, 2023

Currently, the ArcInvestigation.toJsonString function will include all Studies in the output json. In contrast, it will ignore all Assays that are not registered to a Study. Should we go a step further and only include those studies that are registered?
@HLWeil HLWeil added the Type: Bug Something is not working, and it is confirmed by maintainers to be a bug. label Oct 10, 2023
@HLWeil
Copy link
Member Author

HLWeil commented Oct 10, 2023

Sample applies to ArcInvestigation.toFsWorkbook

@HLWeil HLWeil mentioned this issue Oct 10, 2023
Merged
@HLWeil HLWeil closed this as completed Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ArcInvestigation writer fix nfdi4plants/ARCtrl
1 participant
@HLWeil