Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue 258 #259

Merged
merged 5 commits into from
Mar 28, 2017
Merged

Fixes Issue 258 #259

merged 5 commits into from
Mar 28, 2017

Conversation

cwelch5
Copy link
Contributor

@cwelch5 cwelch5 commented Mar 28, 2017

fixes #258

  • test added to showcase bug

@codecov
Copy link

codecov bot commented Mar 28, 2017

Codecov Report

Merging #259 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #259   +/-   ##
=======================================
  Coverage   98.55%   98.55%           
=======================================
  Files           3        3           
  Lines         277      277           
=======================================
  Hits          273      273           
  Misses          4        4
Impacted Files Coverage Δ
src/HelmetUtils.js 98.1% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8504c6...76d82b7. Read the comment docs.

@cwelch5 cwelch5 merged commit 549b603 into master Mar 28, 2017
@tmbtech tmbtech deleted the issue-258 branch May 1, 2019 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Existing title is cleared
1 participant