Add support for anything renderable as children rather than just strings. #272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
We recently upgraded to v5.0.3 and ran across the following error:
![image](https://cloud.githubusercontent.com/assets/1574487/25458716/4d50c5c8-2a98-11e7-8956-fe8462cb4be8.png)
The error is due to only children of type
string
being supported rather than anything renderable. This PR contains a failing test with a example of using JS expressions within children.From React docs https://facebook.github.io/react/docs/jsx-in-depth.html#children-in-jsx
Where children can typically be anything that can be rendered: numbers, strings, elements or an array (or fragment) containing these types (from PropTypes.children)
With the current API, I would expect
children
of these various types to be supported. However for example,<title>
requires thechildren
to bestring
s.To summarize by examples: