fix: Add support for renderable Arrays of strings #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
==========================================
+ Coverage 98.91% 98.92% +<.01%
==========================================
Files 3 3
Lines 277 278 +1
==========================================
+ Hits 274 275 +1
Misses 3 3
Continue to review full report at Codecov.
|
jamsea
approved these changes
May 4, 2017
| @@ -46,6 +46,23 @@ describe("Helmet - Declarative API", () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it("updates page title and allows children containing expressions", (done) => { | |||
| const someValue = "Some Great Title"; | |||
There was a problem hiding this comment.
Should we have a test for const someValue = null too?
ldeavila
reviewed
May 4, 2017
| @@ -187,7 +187,13 @@ const Helmet = (Component) => class HelmetWrapper extends React.Component { | |||
| return warn(`Only elements types ${VALID_TAG_NAMES.join(", ")} are allowed. Helmet does not support rendering <${child.type}> elements. Refer to our API for more information.`); | |||
| } | |||
|
|
|||
| if (nestedChildren && typeof nestedChildren !== "string") { | |||
There was a problem hiding this comment.
Suggestion. Externalize the test into a function. That would make the code more declarative and easier to read on first glance and communicate better intent of the code.
cwelch5
approved these changes
May 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #272