Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deep comparing props in shouldComponentUpdate (usage with preact-compat) #287

Open
bassarisse opened this issue May 30, 2017 · 3 comments
Open

Deep comparing props in shouldComponentUpdate (usage with preact-compat) #287

bassarisse opened this issue May 30, 2017 · 3 comments

Comments

@bassarisse
Copy link

Hey there,

I don't know if usage with preact-compat is something this lib intends to support, so I'll just ask. =)

I opened this issue there: preactjs/preact-compat#391

Is this something that could be fixed in react-helmet? Or should I just replace it with preact-helmet?

Thanks in advance!
@tannerlinsley
Copy link

This affects React-Static users who opt for preact. What's the game plan here?

@kandebr
Copy link

kandebr commented Apr 4, 2018 •
edited
Loading

I'm using react 16.3.* (without preact) and I have the problem.. One of the props in shouldComponentUpdate is object of FiberNode, and this object has recursive link to himself (alternate field) and so deepClone will be crashed..

@esbenam
Copy link
Contributor

esbenam commented May 11, 2020 •
edited
Loading

react-fast-compare just added support for Preact in react-fast-compare@3.1.1. Maybe this could be resolved by upgrading the dependency?

@esbenam esbenam mentioned this issue May 11, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bassarisse @esbenam @tannerlinsley @kandebr