You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently react-metrics throws an exception on this line when the site URI is malformed with an invalid query string: https://github.com/nfl/react-metrics/blob/master/src/core/createMetrics.js#L13
Ideally, querystring.decode would be wrapped in a try/catch, spit the error out in the console and set qs to {} so that the site doesn't partially render due to the unhandled js exception.
We are also trying to correct the invalid query string coming into our site, but we ideally would still render a working site even if the query string is malformed.
The text was updated successfully, but these errors were encountered:
Currently react-metrics throws an exception on this line when the site URI is malformed with an invalid query string:
https://github.com/nfl/react-metrics/blob/master/src/core/createMetrics.js#L13
Ideally,
querystring.decode
would be wrapped in a try/catch, spit the error out in the console and setqs
to{}
so that the site doesn't partially render due to the unhandled js exception.We are also trying to correct the invalid query string coming into our site, but we ideally would still render a working site even if the query string is malformed.
The text was updated successfully, but these errors were encountered: