Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question re: legacy_id_map.csv #13

Closed
DaSkunk opened this issue Jul 12, 2020 · 2 comments
Closed

Question re: legacy_id_map.csv #13

DaSkunk opened this issue Jul 12, 2020 · 2 comments

Comments

@DaSkunk
Copy link

DaSkunk commented Jul 12, 2020

Is the legacy_id_map csv file supposed to contain all the players in the league? The one I downloaded only has 1667 records. (for example it's missing Saquon Barkley). This file will be immensely helpful to correlate new data against historic data I have indexed with the former player_gsis_id #s.

Thank you so much for providing this.

@guga31bb
Copy link
Member

The map is for us to be able to covert everyone who had old IDs (i.e., observed in seasons before 2011) to the new IDs. Since Saquon didn't play before 2011, we don't need to change his ID in any observations. We're abandoning the old IDs because NFL doesn't use them anymore so they're useless going forward (i.e., for rookies in 2020 they won't have old IDs).

I think @ajreinhard has a full map here.

@DaSkunk
Copy link
Author

DaSkunk commented Jul 13, 2020

I understand now, my mistake. I thought only the 2019 pbp data switched to the new ids so I thought the mapping was needed for everything prior to 2019. I see in looking at some of your older JSON, the new IDs are indeed in there. Thank you for clarifying and responding so quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants